Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize collection_subcollection branchname patterns for TreeMakerSchema #619

Merged
merged 8 commits into from
Nov 23, 2021

Conversation

yimuchen
Copy link
Contributor

In TreeMaker, sub-collections are indicated with branch names <collection>_<subcollection> and a counting array <collection>_<subcollection>Counts to indicate sub-collection grouping. Originally, a special case was provided for the most commonly used sub-collection (JetsAK8 and JetsAK8_subjets). In this pull request, we generalized the branch name parsing to allow for arbitrary sub-collection structures to be extracted.

@yimuchen yimuchen changed the title Generalize collection_subcollection branchname patterns Generalize collection_subcollection branchname patterns for TreeMakerSchema Nov 22, 2021
@lgray
Copy link
Collaborator

lgray commented Nov 22, 2021

Could you make a small test for this as well? Like a 10-event treemaker Ntuple to read in and and build the structure of, check for a few branches, etc.

@yimuchen
Copy link
Contributor Author

Should be ready once checks are complete.

@lgray lgray merged commit b8128a4 into scikit-hep:master Nov 23, 2021
@yimuchen yimuchen deleted the treemaker_subcollection branch November 23, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants